Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - v2.2.1 #3149

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - v2.2.1 #3149

wants to merge 2 commits into from

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Addresses sync stalls on v2.2.0 (i.e. #3147).

Additional Info

I've avoided doing a full cargo update because I noticed there's a new patch version of libp2p and thought it could do with some more testing.

@michaelsproul
Copy link
Member Author

Leaving this here pending testing over the weekend on SigP nodes.

@michaelsproul michaelsproul changed the base branch from unstable to stable April 8, 2022 02:12
@michaelsproul michaelsproul changed the base branch from stable to unstable April 8, 2022 02:12
commit aa5d93d
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Apr 8 14:16:44 2022 +1000

    Use existing `execution_engine`
@paulhauner
Copy link
Member

Blocked on #3150

@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed blocked do-not-merge labels Apr 12, 2022
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

bors r+

bors bot pushed a commit that referenced this pull request Apr 12, 2022
## Issue Addressed

Addresses sync stalls on v2.2.0 (i.e. #3147).

## Additional Info

I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing.



Co-authored-by: Paul Hauner <paul@paulhauner.com>
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 12, 2022
@bors
Copy link

bors bot commented Apr 12, 2022

Build failed:

@michaelsproul
Copy link
Member Author

The ole zero port race condition

bors retry

bors bot pushed a commit that referenced this pull request Apr 12, 2022
## Issue Addressed

Addresses sync stalls on v2.2.0 (i.e. #3147).

## Additional Info

I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing.



Co-authored-by: Paul Hauner <paul@paulhauner.com>
@bors bors bot changed the title v2.2.1 [Merged by Bors] - v2.2.1 Apr 12, 2022
@bors bors bot closed this Apr 12, 2022
@michaelsproul michaelsproul deleted the cut-v2.2.1 branch April 12, 2022 05:10
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request May 6, 2022
## Issue Addressed

Addresses sync stalls on v2.2.0 (i.e. sigp#3147).

## Additional Info

I've avoided doing a full `cargo update` because I noticed there's a new patch version of libp2p and thought it could do with some more testing.



Co-authored-by: Paul Hauner <paul@paulhauner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants